Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): implements new auth dialog #14431

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat(auth): implements new auth dialog #14431

merged 1 commit into from
Sep 12, 2024

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Sep 4, 2024 •
edited
Loading

@dzucconi dzucconi requested a review from a team September 4, 2024 13:45
@dzucconi dzucconi self-assigned this Sep 4, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Sep 4, 2024 •
edited
Loading

#268 Bundle Size — 9.49MiB (+0.01%).

914d354(current) vs 3cbc233 main#266(baseline)

Warning

Bundle contains 45 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#268		      Baseline
#266
Regression  Initial JS 4.3MiB(+0.11%) 4.3MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.2% 6.36%
No change  Chunks 141 141
No change  Assets 144 144
Change  Modules 5555(+0.04%) 5553
No change  Duplicate Modules 380 380
No change  Duplicate Code 4.8% 4.8%
No change  Packages 292 292
No change  Duplicate Packages 42 42
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#268		      Baseline
#266
Regression  JS 9.28MiB (+0.01%) 9.28MiB
No change  Other 212.66KiB 212.66KiB

Bundle analysis report Branch review-app-new-auth Project dashboard

Generated by RelativeCI Documentation Report issue

@dzucconi dzucconi force-pushed the review-app-new-auth branch from 5fa6c4b to 607f0d8 Compare September 4, 2024 14:33
@dzucconi dzucconi force-pushed the review-app-new-auth branch 5 times, most recently from 783a23a to 5701a8a Compare September 12, 2024 12:00
@dzucconi dzucconi force-pushed the review-app-new-auth branch 4 times, most recently from 40ca469 to a9a84c5 Compare September 12, 2024 13:27
@dzucconi dzucconi merged commit 87f127d into main Sep 12, 2024
14 checks passed
@dzucconi dzucconi deleted the review-app-new-auth branch September 12, 2024 14:26
@artsy-peril artsy-peril bot mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damassi damassi damassi left review comments

Assignees

@dzucconi dzucconi

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzucconi @damassi