Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] - Review app infinite disco #14997

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

egdbear
Copy link
Contributor

@egdbear egdbear commented Dec 16, 2024

The type of this PR is: Feat

This PR solves [PROJECT-XX]

Description

https://infinite-disco-v2.artsy.net/infinite-discovery

Screenshot 2024-11-21 at 11 32 38 AM
Screenshot 2024-11-21 at 11 32 48 AM

@egdbear egdbear requested a review from a team December 16, 2024 14:14
@egdbear egdbear self-assigned this Dec 16, 2024
@egdbear egdbear requested a review from nickskalkin December 16, 2024 14:14
@ArtsyOpenSource
Copy link

ArtsyOpenSource commented Dec 19, 2024

Warnings
⚠️

Routes added to routes.tsx should have a corresponding cypress.js smoke test. See the cypress/e2e folder for examples.

Generated by 🚫 dangerJS against 9fc2dd4

Copy link

relativeci bot commented Dec 19, 2024

#1382 Bundle Size — 8.96MiB (+0.08%).

9fc2dd4(current) vs f52da8f main#1381(baseline)

Warning

Bundle contains 14 duplicate packages – View duplicate packages

Bundle metrics  Change 6 changes Regression 1 regression
                 Current
#1382
     Baseline
#1381
Regression  Initial JS 3.65MiB(+0.02%) 3.65MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 45.57% 39.32%
Change  Chunks 104(+0.97%) 103
Change  Assets 107(+0.94%) 106
Change  Modules 5836(+0.03%) 5834
No change  Duplicate Modules 529 529
Change  Duplicate Code 4.02%(-0.25%) 4.03%
No change  Packages 266 266
No change  Duplicate Packages 13 13
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#1382
     Baseline
#1381
Regression  JS 8.82MiB (+0.06%) 8.81MiB
Regression  Other 144.68KiB (+0.92%) 143.36KiB

Bundle analysis reportBranch review-app-infinite-disco-v2Project dashboard


Generated by RelativeCIDocumentationReport issue

@egdbear egdbear force-pushed the review-app-infinite-disco-v2 branch from 2595ad7 to 9fc2dd4 Compare December 19, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants