chore(AMBER-1209): Update the class name on css to match the component #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not display the SF chat bubble on the mobile version. We handled this during the migration from Zendesk to SF, but our css rule specifies a class that's defined on SF stylesheet, which became outdated after the recent upgrade. Changes in this PR point update the class name to meet the current definition.
lidimayra
commented
Dec 18, 2024
| .embeddedServiceHelpButton .helpButton .uiButton { | ||
| display: none; | ||
| .embeddedMessagingConversationButton { | ||
| display: none !important; |
There was a problem hiding this comment.
More on the reasoning behind !important usage can be found here
jonallured
approved these changes
Dec 18, 2024
lidimayra
deleted the
lidimayra/AMBER-1209-hide-sf-chat-bubble-on-mobile
branch
Merged
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Chore
This PR solves AMBER-1209
Description
Similar to https://github.com/artsy/volt/pull/8211, but now for collectors
We must not display the SF chat bubble on the mobile version. We handled this during the migration from Zendesk to SF, but our css rule specifies a class that's defined on SF stylesheet, which became outdated after the recent upgrade.
Changes in this PR point update the class name to meet the current definition.
Before
After
cc @artsy/amber-devs