-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy #3214
Conversation
Before this change: the profile app was redirecting all traffic of that didn’t explicitly match another route to it’s app. This was resulting in slow health checks that were integrating with gravity. Considering these health check requests run every 5 seconds, we’re putting a lot of needless traffic on gravity and other potential downstream services. * prettify src/lib/setup.js Co-authored-by: Christopher Pappas <damassi.pappas@gmail.com>
Explicitly added a route for `api/v1/profile/system` that’s implementation was a spy. Use sinon to assert that the spy function is never called. Co-authored-by: Chung-Yi Chi <chung-yi@artsymail.com>
Load health check endpoints before others
add signup modal to news articles
Update dependency @artsy/reaction to v9.1.21
Update dependency @artsy/reaction to v9.1.23
@damassi @xtina-starr could y'all get back to me in the next 2 hours if this is good to deploy or not? |
Generated by 🚫 dangerJS |
Update dependency @artsy/reaction to v9.1.24
👍 from me. |
Update dependency @artsy/reaction to v9.1.25
@xtina-starr and @damassi take a look at the Danger CI's comment above looks like there's meaningful incompatibility between Force's graphql schema and Metaphysics. Can you one of you take a look at this? |
Update dependency @artsy/reaction to v9.1.27
Yup, need to deploy MP! Good work danger. |
Update unsupported browsers list
Hoping to get this out by 11am today for EOY changes, did we get a metaphysics deploy out yet? |
@eessex - not yet, but feel free to ping the MP channel and send it out. |
Peril / Danger are wrong here, I think the technique for doing this wrong somehow, catching maybe? Metaphysics prod is definitely showing the types referenced as not being in there. |
I think this could probably be improved by switching to the technique in |
No description provided.