Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy #3214

Merged
merged 19 commits into from
Dec 19, 2018
Merged

Deploy #3214

merged 19 commits into from
Dec 19, 2018

Conversation

dleve123
Copy link
Contributor

No description provided.

xtina-starr and others added 11 commits December 11, 2018 14:37
Before this change: the profile app was redirecting
all traffic of that didn’t explicitly match another route to it’s
app. This was resulting in slow health checks that were integrating with
gravity. Considering these health check requests run every 5 seconds,
we’re putting a lot of needless traffic on gravity and other potential
downstream services.

* prettify src/lib/setup.js

Co-authored-by: Christopher Pappas <damassi.pappas@gmail.com>
Explicitly added a route for `api/v1/profile/system` that’s implementation
was a spy. Use sinon to assert that the spy function is never called.

Co-authored-by: Chung-Yi Chi <chung-yi@artsymail.com>
Load health check endpoints before others
Update dependency @artsy/reaction to v9.1.21
Update dependency @artsy/reaction to v9.1.23
@dleve123
Copy link
Contributor Author

@damassi @xtina-starr could y'all get back to me in the next 2 hours if this is good to deploy or not?

@DangerCI
Copy link

DangerCI commented Dec 18, 2018

Fails
🚫 Metaphysics production does not have a compatible schema for force's GraphQL usage, please deploy metaphysics to production and re-run Travis CI.
🚫 Missing types: `FairArtistSorts`
🚫 Fields missing: `ShowCounts.artists`, `Fair.artists_count`, `Fair.artists`, `ArtworkContextFair.artists_count`, `ArtworkContextFair.artists`, `HomePageModuleContextFair.artists_count` and `HomePageModuleContextFair.artists`

Generated by 🚫 dangerJS

@xtina-starr
Copy link
Contributor

👍 from me.

@dleve123
Copy link
Contributor Author

@xtina-starr and @damassi take a look at the Danger CI's comment above looks like there's meaningful incompatibility between Force's graphql schema and Metaphysics. Can you one of you take a look at this?

@damassi
Copy link
Member

damassi commented Dec 18, 2018

Yup, need to deploy MP! Good work danger.

@eessex
Copy link
Contributor

eessex commented Dec 19, 2018

Hoping to get this out by 11am today for EOY changes, did we get a metaphysics deploy out yet?

@damassi
Copy link
Member

damassi commented Dec 19, 2018

@eessex - not yet, but feel free to ping the MP channel and send it out.

@eessex eessex merged commit 2e11019 into release Dec 19, 2018
@orta
Copy link
Contributor

orta commented Dec 19, 2018

Peril / Danger are wrong here, I think the technique for doing this wrong somehow, catching maybe? Metaphysics prod is definitely showing the types referenced as not being in there.

@orta
Copy link
Contributor

orta commented Dec 19, 2018

I think this could probably be improved by switching to the technique in
artsy/peril-settings#86 which will use a check with the images to detect differences with prod/staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants