Pull inConfirmRegistrationModal from Reaction #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
commented
Sep 3, 2019
| @@ -76,7 +76,7 @@ describe("Confirm Registration Modal", () => { | |||
| it("shows a qualified message", () => { | |||
| const { wrapper } = renderTestComponent({ | |||
| Component: ConfirmRegistrationModal, | |||
| options: { renderMode: "render" }, | |||
| options: { renderMode: "mount" }, | |||
There was a problem hiding this comment.
render did not work and rendered nothing with the PostRegistrationModal component in Reaction. Not sure why it's working with mount even after reading enzymejs/enzyme#465 (comment).
Codecov Report
@@ Coverage Diff @@
## master #4484 +/- ##
========================================
- Coverage 79.3% 79.1% -0.2%
========================================
Files 1269 1269
Lines 34994 35439 +445
Branches 2008 2036 +28
========================================
+ Hits 27768 28055 +287
- Misses 6242 6335 +93
- Partials 984 1049 +65 |
Codecov Report
@@ Coverage Diff @@
## master #4484 +/- ##
========================================
- Coverage 79.3% 79.2% -0.1%
========================================
Files 1269 1269
Lines 35082 35136 +54
Branches 1987 2037 +50
========================================
+ Hits 27831 27854 +23
- Misses 6236 6278 +42
+ Partials 1015 1004 -11 |
yuki24
changed the title
|
did Self-QA and all green, so #mergeongreen. |
dleve123
reviewed
Sep 4, 2019
Merged
This was referenced Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses https://artsyproduct.atlassian.net/browse/AUCT-571
This replaces the duplicate auction registration copies & modals with the one in Reaction.
Todos