Allow reaction linking from force #4498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4498 +/- ##
========================================
+ Coverage 79.1% 79.3% +0.1%
========================================
Files 1270 1270
Lines 35045 35032 -13
Branches 2021 2022 +1
========================================
+ Hits 27752 27781 +29
+ Misses 6287 6260 -27
+ Partials 1006 991 -15 |
scripts/quicklink-to-project.sh
Outdated
| cat package.json | jq -e .scripts.integrate &>2 | ||
|
|
||
| if [ $? -ne 0 ]; then | ||
| echo "$PROJECT doesn't have integrate npm script, ensure it's valid" |
There was a problem hiding this comment.
Maybe reference something that would make it valid?
There was a problem hiding this comment.
Like pointing to another project?
There was a problem hiding this comment.
Or something -- a random dev won't know what "ensure it's valid' means.
There was a problem hiding this comment.
And/or perhaps re-word it so people know to look at the scripts key of package.json? I’m not sure “npm scripts” is something everybody will immediately understand.
There was a problem hiding this comment.
I updated the wording a little bit. I'm gonna write a blog post and some more detailed documentation on this process this week so I'll follow up once that's done.
This is just the other direction from #4475. It does the same thing (links reaction into force), but it allows you do to so from force.
So you'd run
and that'd start up the linking process. I need to add some docs still.