Drops old feature apps; renames feature-reaction app => feature #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzucconi
commented
May 21, 2020
dzucconi
commented
May 21, 2020
damassi
reviewed
May 27, 2020
damassi
reviewed
May 27, 2020
damassi
reviewed
May 27, 2020
dzucconi
force-pushed
the
fix/removes-old-feature-pages
branch
from
248ab44
to
572c6af
Compare
Error RangeErrorDangerfile |
Duplicate Sources / Packages - Duplicates found!
|
sweir27
reviewed
May 28, 2020
| @@ -28,7 +28,6 @@ routes = | |||
| /auction-registration/.* | |||
| /auction/.*/bid/.* | |||
| /auction/.*/buyers-premium | |||
| /feature/.*/bid/.* | |||
There was a problem hiding this comment.
This seems like it should be fine, but this change worries me (is it possible this route is currently active?)
There was a problem hiding this comment.
I can pull this change off but I was assuming it was for when features supported sales, we'd link to bid pages from within that app — there wasn't a proper auction to fetch so the auction route wouldn't be valid but you'd still want to bid. At least this is what I think I remember.
There was a problem hiding this comment.
Ahh interesting. I wonder if it's possible to verify (or at least mention to #product-auctions). I suspect you're right but want to be sure.
There was a problem hiding this comment.
I feel like this route has been marked for removal in the past somewhere - like in a routes.coffee or something - with a note like 'TODO: figure out if we are still using this or remove'. I think i wrote something like this a year or so ago 😬
|
✂️ ✂️ ✂️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I absolutely may have. missed a step here so do give this a look. I won't convert this out of draft until we're ready.