Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger auth modal upon first user interaction. #5650

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Trigger auth modal upon first user interaction. #5650

merged 1 commit into from
Jun 9, 2020

Conversation

artsyjian
Copy link
Contributor

@artsyjian artsyjian commented May 26, 2020

https://artsyproduct.atlassian.net/browse/PURCHASE-1926

Trigger auth modal when user change filters/page for the 1st time. Ask for artist name in GraphQL query, and show it in modal copy.

@ArtsyOpenSource
Copy link

ArtsyOpenSource commented May 26, 2020

Fails
🚫

Danger failed to run dangerfile.ts.

Error RangeError

Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at Object.skipSpace (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6637:12)
    at Object.nextToken (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6573:56)
    at Object.next (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6527:10)
    at Object.parseLiteral (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8999:10)
    at Object.parseExprAtom (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8821:21)
    at Object.parseExprAtom (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:3609:20)
    at Object.parseExprSubscripts (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8483:23)
    at Object.parseMaybeUnary (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8463:21)
    at Object.parseExprOps (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8329:23)
    at Object.parseMaybeConditional (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8302:23)

Dangerfile

----------------^

Generated by 🚫 dangerJS against 354faaf

@artsyjian artsyjian changed the title Trigger auth modal upon first user interaction. Trigger auth modal upon first user interaction. (Depends on PR#5648) May 26, 2020
@artsyjian artsyjian changed the title Trigger auth modal upon first user interaction. (Depends on PR#5648) Trigger auth modal upon first user interaction. May 28, 2020
@damassi
Copy link
Member

damassi commented Jun 9, 2020

@zephraph - can this be merged?

@zephraph zephraph merged commit d17d03c into artsy:master Jun 9, 2020
@zephraph
Copy link
Contributor

zephraph commented Jun 9, 2020

Crap, yeah. It fell off my radar. Thanks for the ping @damassi

@artsy-peril artsy-peril bot mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants