Update NSO and inquiry FAQ link on artwork sidebar (PURCHASE-1885) #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsirius
commented
Jun 4, 2020
| .find('a[children="Conditions of Sale"]') | ||
| .at(0) | ||
| .simulate("click") | ||
| wrapper.find('a[children="Conditions of Sale"]').at(0).simulate("click") |
There was a problem hiding this comment.
Sorry for the large diff here. Looks like there was some prettier update that caused the format changes. Probably safe to ignore.
starsirius
commented
Jun 4, 2020
| @@ -137,37 +125,33 @@ describe("ArtworkSidebarExtraLinks", () => { | |||
| }) | |||
| it("displays proper text", () => { | |||
| expect(wrapper.text()).toContain( | |||
| "Have a question? Read our FAQ or ask a specialist." | |||
| "Have a question? Visit our help center or ask a specialist." | |||
There was a problem hiding this comment.
These are real changes.
starsirius
commented
Jun 4, 2020
| @@ -150,7 +154,9 @@ ArtworkSidebarExtraLinksContainerProps | |||
| return ( | |||
| <Container> | |||
| Have a question?{" "} | |||
| <Link onClick={this.onClickBuyNowFAQ.bind(this)}>Read our FAQ</Link>{" "} | |||
| <Link onClick={this.onClickBuyNowFAQ.bind(this)}> | |||
| Visit our help center | |||
There was a problem hiding this comment.
Noticed that we track clicks for Buy Now FAQ link and Collector FAQ link below. I assume the CTA copy changes may effect how users interact with the page. Do we want to modify the tracking or are we fine keeping the existing tracking as is? cc @anipetrov
There was a problem hiding this comment.
let's change the label property to the new CTA please!
zephraph
reviewed
Jun 4, 2020
src/v2/Apps/Artwork/Components/ArtworkSidebar/ArtworkSidebarExtraLinks.tsx
Show resolved
Hide resolved
zephraph
approved these changes
Jun 4, 2020
starsirius
force-pushed
the
faq-link-update
branch
from
275f9ca
to
bb667e7
Compare
|
Merging! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/PURCHASE-1885