Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Hot Reload Refactor #6783

Merged
merged 2 commits into from
Dec 10, 2020
Merged

feature: Hot Reload Refactor #6783

merged 2 commits into from
Dec 10, 2020

Conversation

icirellik
Copy link
Contributor

Unblocks in progress Novo work and moves the temporary hot
reloading to a more appropriate location.

@icirellik icirellik self-assigned this Dec 10, 2020
@artsy-peril artsy-peril bot merged commit 082a01e into master Dec 10, 2020
@artsy-peril artsy-peril bot deleted the feature-temp-hot-reload branch December 10, 2020 14:52
@artsy-peril artsy-peril bot mentioned this pull request Dec 10, 2020
Merged
damassi
damassi reviewed Dec 10, 2020
View reviewed changes
src/common-app.js
})
} else {
app.use("/", require("./novo/src/server"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damassi damassi damassi left review comments

Assignees

@icirellik icirellik

Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icirellik @damassi