Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around PEP-517 pip build system installing dev dependencies #220

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

izakp
Copy link
Contributor

@izakp izakp commented Aug 11, 2020

I started to get errors installing hokusai via pip install . in a Docker container due to unavailable gcc tools and realized introducing the pyproject.toml file caused pip to use poetry as its build system which then installed dev dependencies.

Pip introduced support for PEP-517 -- A build-system independent format for source trees in version 10 which respects the pyproject.toml file and support for the build-backend in version 19. These errors only manifest while running on pip version 19 or 20 so followed the lead of this PR to default to the legacy build backend (i.e. setuptools).

Here are similar issues:

pip install -e . / pip install . now work as expected and only install dependencies specified in setup.py. It may be nice in the future to use poetry as a production build backend but will require further investigation.

@izakp
Copy link
Contributor Author

izakp commented Aug 12, 2020

Going to merge this to ensure pip installs from master work properly

@izakp izakp merged commit d9390c1 into artsy:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants