[WIP] Upgrade to Rails 6.0, add webpacker & react #72
Conversation
There was a problem hiding this comment.
I don't profess to understand most of this, but I assume it's mostly boilerplate for combining rails + webpack + react?
What's the motivation for adding react in particular? I'm biased, but in addition to requiring more/different engineering skills to make updates, it risks making tests less trustworthy (unless we also adopt a complex full browser harness).
| @@ -2,9 +2,9 @@ | |||
| version: "2" | |||
| services: | |||
| horizon: | |||
| env_file: ../.env | |||
There was a problem hiding this comment.
One problem we've had in other projects is that hokusai dev will fail if this file isn't found. If you've found this useful, you might want to add a step to the set-up described in the README.
| environment: | ||
| - RAILS_ENV=development | ||
| - RAILS_LOG_TO_STDOUT=true |
There was a problem hiding this comment.
Why remove this? (Do the defaults change in rails 6? If so the code that references it in the environment files can be removed.)
There was a problem hiding this comment.
We reference this in the build.yml so it shouldn't need to go into individual environments.
|
Perhaps this is my own bias because I'm inexperienced with haml, but I was frustrated by the difficulty of sharing styles/components/theme in the current setup. By using Palette I hope to significantly speed up the time it takes to build out views and eliminate the need to worry about theming. |
|
I don't think there's any HAML here! Just the ERB that's pretty rails-standard (and would remain whether react is in the picture or not). If this is just about sharing partials or assets, I'd encourage you to give the existing pattern a shot. It shouldn't be too much of an obstacle, and I don't think we should switch to client-side rendering without a bigger reason. |
DO NOT MERGE
Pair project with @jpotts244