Migrate asset pipeline to Webpack, use TS & React #95
Conversation
| consumer.subscriptions.create( | ||
| { | ||
| channel: "ProjectChannel", | ||
| organization_id: $("#organization_subscription_identifier").val(), |
There was a problem hiding this comment.
If jquery isn't cool and you prefer a more modern/react-friendly alternative, this might be its only usage.
There was a problem hiding this comment.
Oo good call - going to make a follow-up task to remove jQuery and update this logic.
|
@jonallured - not sure what volts setup looks like, but at the min we should turn on |
There was a problem hiding this comment.
Whoa, nice one!! I don't have much to add here other than props for this heroic work. 🏆
Oh I do have one suggestion: by convention the default rake task on a Rails project runs all the linters/formatters/tests so I setup Convection like so:
https://github.com/artsy/convection/blob/master/Rakefile#L34
And then Circle just runs that same task:
https://github.com/artsy/convection/blob/master/hokusai/ci.sh#L29
I think this is handy because it means while deving I can run a bundle exec rake and if it's green then I can reliably predict that CI will be green too. I realize that some of this is unnecessary for those that use VS Code and git hooks, but I think it's worth it to set this up so as to be friendly to other setups. What do you think?
|
@jonallured excellent suggestion! I've added a default rake task and am running prettier there now. |
| "dependencies": {} | ||
| "scripts": { | ||
| "lint": "eslint ./app --ext ts,tsx,js,jsx --fix", | ||
| "prettier": "prettier --write 'app/**/*.(ts|tsx|js|jsx)'", |
There was a problem hiding this comment.
I think you'd want an additional script like this:
https://github.com/artsy/convection/blob/master/package.json#L6
This ensures that the rake task will fail if there are prettier violations - otherwise the rake task will write those files and happily return 0!!
There was a problem hiding this comment.
Will follow up to add this & rubocop
Adds TS/React front end toolchain:
webpackergem and compile JS assets via Webpacktypescript,react,@artsy/paletteandstyled-components