This repository was archived by the owner on May 18, 2022. It is now read-only.
Update Kaws' CSV import script to also update the sitemap seed JSON #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
commented
Dec 17, 2018
| import { Collection } from "../src/Entities" | ||
| import { loadCsvAsCollection } from "./loadCsvAsColleciton" | ||
|
|
||
| const AWS = require("aws-sdk") |
There was a problem hiding this comment.
I'm not sure why not import did not work but require did...
There was a problem hiding this comment.
did you try import * as AWS from "aws-sdk"
|
Closing as I'll have to re-write the entire script to use MongoDB. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finishes https://artsyproduct.atlassian.net/browse/GROW-1051
aws-sdkdependencyconvertCSVToJsoninto its own file soscripts/bootstrapOrUpdate.tsandscripts/updateSitemapJson.tsshare the logicyarn update-sitemap ./collections.csvthat updates the S3 objectTodo