Viewer fix for statuses #2593
Merged
Viewer fix for statuses #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzikherman
approved these changes
Aug 7, 2020
mdole
approved these changes
Aug 7, 2020
| @@ -137,7 +137,7 @@ export const gravityStitchingEnvironment = ( | |||
| } | |||
|
|
|||
| extend type Viewer { | |||
| viewingRoomsConnection(first: Int, after: String): ViewingRoomConnection | |||
| viewingRoomsConnection(first: Int, after: String, statuses: [ViewingRoomStatusEnum!]): ViewingRoomConnection | |||
There was a problem hiding this comment.
Wanted to make sure I understood the syntax of [ViewingRoomStatusEnum!]; i.e. what exactly can be null, and found this handy reference: https://graphql-ruby.org/type_definitions/lists.html#nullable-lists-with-non-null-items
TL;DR we can pass nil for statuses, but if a list is present, it has to include value(s) of type ViewingRoomStatusEnum. Sounds right to me!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
statusesfield in the viewer we created for force forviewingRoomsI tried adding a test for
inputFields include statuses, but I couldn't add this in an easy way.I tried getting it by using something like
getFieldsForTypeFromSchemabut for inputFields, but there is no "type" that these are attached to.I did find and try this which worked and gave me the whole schema basically. I'm sure we could use this in a test and get everything and them map it in an object that we can ask like
Viewer.viewingRoomsConnection.inputFields includes statuses.