feat: remove partner offer from primary label #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsirius
force-pushed
the
starsirius/remove-offer-from-primary-label
branch
from
f555482 to
90be548
Compare
starsirius
changed the title
starsirius
force-pushed
the
starsirius/remove-offer-from-primary-label
branch
from
90be548 to
2e44c56
Compare
starsirius
changed the title
|
OK I moved this change behind a feature flag, so we can release things incrementally. This should be ready for review and hopefully merge! 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE YET. Will need to coordinate deploy with artsy/force#14897, and we might want to include tracking changes.As this work becomes too complex to manage now it requires analytics changes. I decided to guard it behind a feature flag so we can continuously and incrementally deliver (vs. releasing all at once).To load and render the partner offer signals on the client-side and still render other primary labels (e.g. "increased interest" and "curators' pick") server-side, we'd want to remove partner offer from the
primaryLabelfield.The separation of authenticated and unauthenticated data into different fields is also more aligned with schema design (although I agree the name now can be a bit confusing).
Note that I didn't remove it from the enum as I don't want to introduce breaking schema changes. I can follow up separately once the main work is in.