-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FX-4495): RabbitMQ event when an article is published / un-published #3083
feat(FX-4495): RabbitMQ event when an article is published / un-published #3083
Conversation
7617223
to
9b7279b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3083 +/- ##
=======================================
- Coverage 83.1% 83.0% -0.1%
=======================================
Files 196 197 +1
Lines 5385 5412 +27
Branches 988 989 +1
=======================================
+ Hits 4477 4497 +20
- Misses 656 662 +6
- Partials 252 253 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice refactoring 👍🏼
) | ||
} | ||
|
||
module.exports = { amqp } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion / non-blocking: As this is a new file, might be nice to have it in TypeScript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do in a separate PR this week!
amqplibAuthor: Michael Bridgen Description: An AMQP 0-9-1 (e.g., RabbitMQ) library and client. Homepage: http://amqp-node.github.io/amqplib/
|
Emits a RabbitMQ message when an article is published.
Deployment