@zephraph => [TSLint] Rule to warn about using QueryRenderer

[mzikherman]

Starting out with a naive rule using just string comparison...will see if an AST if needed.

This is a WIP since it's still not actually working. Getting:

Error: Severity for rule 'noQueryRendererImport' not found

[mzikherman]

Thanks for the feedback! After editing the TSLint runner to avoid this severity error, I was able to get it to run, but of course the text based solution isn't going to cut it.

I was in the weeds since it also seems as though the way I'm specifying an error here, doesn't seem to quite work with our TSLint version, re: the missing severity thing. Was seeing some issues there: palantir/tslint#2650

But I think the AST-style rule will naturally return failures that are differently structured, which might avoid that issue altogether!

[codecov]

Codecov Report

Merging #3108 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3108   +/-   ##
======================================
  Coverage      82%     82%           
======================================
  Files         743     743           
  Lines       10883   10883           
  Branches     2182    2182           
======================================
  Hits         8933    8933           
  Misses       1365    1365           
  Partials      585     585

[mzikherman]

Assigning to @eessex - this adds a linter rule which fails (you can always disable the rule per line) if you use QueryRenderer (over the preferred SystemQueryRenderer).

The linter did locate one such location in Tooltips that was still using QueryRenderer, so made the recommended update (is that safe btw)?

Also cc @damassi I was expecting more violations but I think the sweep you did caught all of them! 👍 🙏 👏

[eessex]

I just pulled down this branch and checked out the tooltips, everything looks good from here 👍

[artsyit]

🚀 PR was released in v24.4.1 🚀

[damassi]

Nice @mzikherman 👍