Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (PLATFORM-3528) update node version to 14LTS, update README #3705

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

ovasdi
Copy link
Contributor

@ovasdi ovasdi commented Sep 20, 2021

https://artsyproduct.atlassian.net/browse/PLATFORM-3528

  • bump Node version to 14LTS
  • edit README

@ovasdi ovasdi added the Version: Trivial This indicates that the PR does not need a deploy label Sep 20, 2021
@ovasdi
Copy link
Contributor Author

ovasdi commented Sep 20, 2021

It seems that the automated integration process with force has been removed. I tried running yarn integrate force and experienced the following: Quicklink script not found at ../force/scripts/quicklink.sh, this project might not be compatible. I wonder if Developing in Force section should be removed then?

I've labeled this PR as Trivial, @icirellik should this be labeled differently?

Copy link
Contributor

@icirellik icirellik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@icirellik
Copy link
Contributor

icirellik commented Sep 22, 2021

I think it's fine to remove the "Developing in Force" section if it's no longer compatible. Sounds like a change that would be better handled in a separate PR.

@icirellik icirellik merged commit c47b11b into master Sep 22, 2021
@icirellik icirellik deleted the ovasdi/PLATFORM-3528/node-14-upgrade branch September 22, 2021 14:46
@artsyit
Copy link
Contributor

artsyit commented Apr 7, 2022

🚀 PR was released in v29.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Trivial This indicates that the PR does not need a deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants