This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ansor4 (this is the finished work we were pairing on initially)
The previous approach for grabbing images was a little overly complex and faulty. Previously we were doing a get request for the image and piping that to s3. While it should've worked well enough, some images were getting gated behind a redirect that even will the follow option the fetch call wasn't able to resolve.
Instead of that approach I configured our gcloud service account to directly access the drive folder w/ our team nav photos. This has the added benefit that we don't need to have that folder public.
Setting up the permissions for the drive were a bit finicky because it expects google permissions to be provided via a file. So, I added a script to write the file from our saved env var. A bit of an ugly hack, but we can revisit that.
Given that the gcloud credentials are needed at build time, it took a few manual config updates:
G_CREDS
environment variable tovars.yml
. This is a bit of a manual processdockerfile
so it's properly available at build timebuild.yml
so that env vars from the vars.yml are supplied to the dockerfile