Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-2106] - Volley test suite improvements #42

Merged
merged 12 commits into from
Jan 22, 2020
Merged

[PLATFORM-2106] - Volley test suite improvements #42

merged 12 commits into from
Jan 22, 2020

Conversation

brainbicycle
Copy link
Contributor

  • Adding jest, converting existing tests to jest
  • Adding dotenv and using in tests
  • Remove mocha
  • Add test coverage and reporting

coauthored with @eessex

@brainbicycle brainbicycle changed the title [PLATFORM-2106] - Volley test suite improvements WIP - [PLATFORM-2106] - Volley test suite improvements Jan 21, 2020
@eessex
Copy link
Contributor

eessex commented Jan 22, 2020

Is this still WIP?

@brainbicycle brainbicycle changed the title WIP - [PLATFORM-2106] - Volley test suite improvements [PLATFORM-2106] - Volley test suite improvements Jan 22, 2020
@brainbicycle
Copy link
Contributor Author

Is this still WIP?

Nope, this is good to go, sorry forgot to change.

eessex
eessex approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@eessex eessex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this is a great improvement!

@eessex eessex merged commit a68dac2 into artsy:master Jan 22, 2020
@artsy-peril artsy-peril bot mentioned this pull request Jan 22, 2020
Merged
@brainbicycle brainbicycle deleted the jest branch January 22, 2020 22:20
@izakp
Copy link
Contributor

izakp commented Jan 23, 2020

Woo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eessex eessex eessex approved these changes

Assignees

@izakp izakp

@eessex eessex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brainbicycle @eessex @izakp