Skip to content

The require.paths is no longer supported in the new version of node. So ...#10

Open
doitdistributed wants to merge 1 commit intoarturadib:masterfrom
doitdistributed:patch-2
Open

The require.paths is no longer supported in the new version of node. So ...#10
doitdistributed wants to merge 1 commit intoarturadib:masterfrom
doitdistributed:patch-2

Conversation

@doitdistributed
Copy link
Contributor

...the custom packages should be moved to node_modules

…So the custom packages should be moved to node_modules
@arturadib
Copy link
Owner

Hey, this is great. Do you mind completing the patch by removing the line (instead of commenting it out), and moving aws-lib to node_modules ?

I think this will require introducing an exception to .gitignore for node_modules/aws-lib.

Thanks!

@doitdistributed
Copy link
Contributor Author

No problem I will make it. I was not absolutely sure if you wanted to migrate to the new version. But now I know :-)

@doitdistributed
Copy link
Contributor Author

ok my forked version is now complete and on v0.6.5 https://github.com/doITdistributed/simpledb-webview

@arturadib
Copy link
Owner

So it seems like the pull requests #14 and #13 make it so that aws-lib is installed via npm. The problem is that there's a bug with aws-lib v0.5.0 which I fixed here:

https://github.com/arturadib/simpledb-webview/blob/master/custom_modules/aws-lib/lib/aws.js#L100

So if you use npm's default aws-lib, that will bring back the ! bug.

I think the solution is to find a way to use the bundled aws-lib without using require.paths.

@doitdistributed
Copy link
Contributor Author

Shouldn't we submit the fix to the aws-lib then?

@arturadib
Copy link
Owner

Shouldn't we submit the fix to the aws-lib then?

It has been fixed but apparently never updated on npm:

https://github.com/livelycode/aws-lib/blob/master/lib/aws.js#L101

@doitdistributed
Copy link
Contributor Author

hmpf :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants