make IBAN random generation independent per IBAN #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create new instances of Randoms where necessary, so that adding/removing IBAN entries won't affect any IBANs that are subsequently generated. - update tests to use assertAll, so it's easier to check & update each value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes IBAN random generation independent per IBAN.
This should prevent problems in the future where an IBAN Structure is modified.
Adjusting the behaviour like this is just one option to fix it, the other would be to update the tests (although I'm not sure how that can be done...).
Summary
Verification
I had a quick play around to verify it by adjusting the structure of
GLand verifying only one of theibanBuilderConstructionSeeded()tests failed. I'd appreciate it if you could take a more thorough look :)Fix #91