Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nationalCheckDigit validation #75

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

hajk1
Copy link
Collaborator

@hajk1 hajk1 commented Oct 21, 2020

Adding more validation for 'nationalCheckDigit' presence if it is mandatory according to the BBAN structure.
Fixes #71

dependabot bot and others added 24 commits October 2, 2023 11:35
- remove deprecated parent pom
- bump java version to 1.8
- add maven wrapper
- bump versions
- change broken project URL to GitHub project URL
- add maven wrapper
Added correct BbanStructure for Gabon and included Test case
Co-authored-by: Remy Duval <remy.duval@nickel.eu>
* update junit version to 5

* update junit version to 5

* test cases refactored

* test cases refactored

* test cases refactored

* test cases refactored to new class

* test cases refactored

* test cases refactored

* test cases refactored

* Parametrized test cases refactored

* Hamcrest test cases refactored

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case
* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action
* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* testing github action
* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* testing github action

* update java adopt jdk badge
hajk1 and others added 27 commits October 2, 2023 11:38
* update java adopt jdk badge

* adding non default padded character

* adding branch code to use padding left

* change the README.md

* release 3.2.6-RELEASE
* adding two new methods

* adding test for the isValid false results

* adding missing tests

* adding valid tests for isValid
* add GHA for maven verify

* add GHA for maven verify

* add test report step

* experimenting with some other reporting actions

* tweaking GHA

* tweaking GHA

* tweaking GHA

* tweaking GHA

* rm broken/buggy test report actions

* try fixing jacoco report

* rm jacoco report upload

* rm jacoco report upload

* rm jacoco report upload
updated to show 3.2.7 release
* Adding Cap Verde structure

* Adding tests for CV

---------

Co-authored-by: RHoog <romain.hoog@kshuttle.io>
* fix spelling mistake, ibanContruction -> ibanConstruction

* add overload to allow passing a custom Random

- add toString() to BbanStructureEntry.java
- tests to check if randomness is deterministic
- add additional tests for validity of BbanStructureEntry.java
- TODO figure out if 'c' can generate a-z

* remove TODO - a-z is not required

* fix code suggestions/warnings

* update tests to JUnit5

* remove duplicated `ibanConstructionRandom()` test

* update assertions

* fix test name after merge

* update expected random values

* re-add accidentally removed test

---------

Co-authored-by: aSemy <aSemy@users.noreply.github.com>
# Conflicts:
#	pom.xml
#	src/test/java/org/iban4j/IbanTest.java
Added correct BbanStructure for Gabon and included Test case
* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action
Added correct BbanStructure for Gabon and included Test case
* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action
…mote-sync

# Conflicts:
#	pom.xml
#	src/test/java/org/iban4j/IbanTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants