update Maven config #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove deprecated parent pom - bump java version to 1.8 - add maven wrapper - bump versions - change broken project URL to GitHub project URL - add maven wrapper
aSemy
commented
Aug 19, 2022
| @@ -23,13 +25,14 @@ | |||
| <packaging>jar</packaging> | |||
|
|
|||
| <name>iban4j</name> | |||
| <description>A Java library for International Bank Account Number (IBAN) generation.</description> | |||
| <url>http://iban4j.org</url> | |||
There was a problem hiding this comment.
This URL is broken for me, and doesn't load. It's also on the GitHub 'about' page. As a quick fix, I removed it here.
hajk1
approved these changes
Aug 19, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some problems building the project locally. I saw that some of the Maven config is out of date, so I made some updates
Prep work for #91