added support for setup without calibrationFile to track and draw 2d #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perhaps it's better to change the name of the new setup to setup2d? the way it is now, it might seem that there's some kind of default calibration and it might be confusing |
|
that's a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if nothing is passed to camParams on ofxAruco::setup() then camParams.isValid() will be false and 3d pose estimation won't be performed by Aruco, which is fine if you wan't to work in 2d only. Also, refactored ofxAruco::draw() method to be:
void ofxAruco::draw()
{
if ( camParams.isValid() )
draw3d();
else draw2d();
}