Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs tests #40

Closed
chrispahm opened this issue Nov 21, 2019 · 1 comment
Closed

Needs tests #40

chrispahm opened this issue Nov 21, 2019 · 1 comment

Comments

@chrispahm
Copy link
Collaborator

Re-occuring issues as #39 show that this plugin is in need of some well defined tests.

The tests should cover

  • dragging on all types of charts is working
  • dragging on stacked charts is working
  • dragging to 0 is working
  • the callbacks are provided with the correct function arguments
  • rounding of values is working correct
  • dragData: false within a dataset is working as expected
  • touch device support

Did I forget something? I will try my best to review open PRs, and get started with writing these tests in the coming weeks. However, help would be greatly appreciated!

@artus9033
Copy link
Owner

Since the tests introduced in #132, #97, #120, #140 and the coverage level reported in codecov is $\approx 90\%$, this issue can
now be closed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants