Use up-to-date configuration reference in callbacks #125
Conversation
**Summary** Callbacks are registered during `afterInit`, however they were using a fixed reference to the `dragData` object using the chart instance object at time of initialization. That's fine *only* if the configuration options never change. However if, as was the case for me, the user is changing their callback definitions and updating the options object accordingly, the new callbacks would never be used by this plugin. **Test Plan** - Instantiate a chart with one set of callbacks - Rerender the chart with a new set of callbacks - Plugin uses the most recent callbacks
|
@chrispahm any thoughts on this? |
|
Hey @mf-bruce, I'm sorry for taking so long to answer, I don't work with Chart.js anymore so this work just comes on top of the other things... If you're interested in maintaining this repo (maybe @artus9033?) please write me a short mail (see profile)! Note that there are still a lot of test cases missing (see #40), plus there are no unit test at all! This is the main reason why I started lagging behind all these PRs and issues, as all options need to be tested manually after each update. Maybe Github Copilot / ChatGPT could be of help writing these test but I wouldn't be too sure about it... |
|
This change is already present in the current v3.0.0, I implemented it in a very similar way during rewrite in TS in #146 |
Summary
Callbacks are registered during
afterInit, however they were using a fixed reference to thedragDataobject using the chart instance object at time of initialization. That's fine only if the configuration options never change. However if, as was the case for me, the user is changing their callback definitions and updating the options object accordingly, the new callbacks would never be used by this plugin.Test Plan