fix: broken plugin and tests after #115 #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
While #115 introduced changes that fixed some bugs, at the same time it carried some logic changes to improve code quality and add more clear configuration priority handling that appeared to be faulty and thus cause E2E tests to fail. Since #115 was an external fork, CI status checks were not shown and it has been merged.
This PR adds:
checkDraggingConfiguration
and proper unit tests for this function to relieve the above problemtest.step
blocks to E2E tests to make logs more intuitive to readsetupChartInstance
test utility so that there is no chance changes to chart properties are persisted across testsbeforeEach
block inconfigurationChanges.spec.ts
(it has been run multiple times for each test)Linked issues (if any)
Checklist before requesting a review