Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken plugin and tests after #115 #143

Merged
merged 10 commits into from
Aug 15, 2024

Conversation

artus9033
Copy link
Owner

Describe your changes

While #115 introduced changes that fixed some bugs, at the same time it carried some logic changes to improve code quality and add more clear configuration priority handling that appeared to be faulty and thus cause E2E tests to fail. Since #115 was an external fork, CI status checks were not shown and it has been merged.

This PR adds:

  • checkDraggingConfiguration and proper unit tests for this function to relieve the above problem
  • reorganized jest configuration so that options that are only allowed in global configuration (e.g. coverage-related ones), are not located in project configuration
  • adds test.step blocks to E2E tests to make logs more intuitive to read
  • adds deep-copying to setupChartInstance test utility so that there is no chance changes to chart properties are persisted across tests
  • enables verbose logging in jest tests to show test suites with their titles as they are run
  • speeds up E2E tests a bit thanks to moving a beforeEach block in configurationChanges.spec.ts (it has been run multiple times for each test)

Linked issues (if any)

Checklist before requesting a review

  • E2E tests' snapshots (screenshots) are up-to-date
  • documentation is up-to-date

@artus9033 artus9033 merged commit 92a363e into master Aug 15, 2024
5 checks passed
@artus9033 artus9033 added the bug label Aug 15, 2024
@artus9033 artus9033 added this to the v2.3.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant