Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overlaying spectra #646

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Add support for overlaying spectra #646

merged 2 commits into from
Aug 28, 2022

Conversation

suzil
Copy link
Collaborator

@suzil suzil commented Aug 27, 2022

Screen.Recording.2022-08-27.at.5.10.03.PM.mov

(The missing ylabel has been fixed, don't want to re-demo it)

I've changed the UI slightly from the ticket to instead have:

  • Create: plots the given spectra, replacing the existing plot
  • Add: Adds a new spectra

Would a different UI be better?

I hope it's OK @arunavabasu-03 that I took this ticket 🙈

Closes #452

@suzil suzil changed the title Overlay spectra 452 Add support for overlaying spectra Aug 27, 2022
@suzil suzil marked this pull request as ready for review August 27, 2022 21:08
@suzil suzil requested review from arunavabasucom and erwanp August 27, 2022 21:08
@suzil suzil force-pushed the overlay-spectra-452 branch 2 times, most recently from 4c44d48 to 4741742 Compare August 27, 2022 21:18
@erwanp
Copy link
Collaborator

erwanp commented Aug 27, 2022

@minouHub you'll love it

@suzil
Copy link
Collaborator Author

suzil commented Aug 27, 2022

There's some issue with the species I still need to figure out (you'll notice duplicated labels on the legend), just noticed it

@erwanp
Copy link
Collaborator

erwanp commented Aug 27, 2022

This is a very game-changing feature ! From a physics point of view, it allows very interesting thing :

  • compare databases ! (therefore, maybe the database should be in the legend? We might be able to re-use @arunavabasu-03 's filename [Database, Molecule, Temperature, Pressure, etc. ] )
  • also, compare interaction of spectra ; i.e. ; compute CO spectrum (1), compute a CO2 spectrum (2), and compare with the overlap of a CO+CO2 spectrum (3)

I like the Add to Plot syntax rather than the originally suggested Clear button. I'd keep that. Maybe we could rename "Create Plot" to "New Plot" ?

@suzil
Copy link
Collaborator Author

suzil commented Aug 27, 2022

Screen Shot 2022-08-27 at 6 43 05 PM

@erwanp how is this?

@suzil
Copy link
Collaborator Author

suzil commented Aug 27, 2022

Fixed unit of pressure from atm to bar ^

@suzil suzil force-pushed the overlay-spectra-452 branch from 4741742 to 43ebad2 Compare August 27, 2022 22:52
@erwanp
Copy link
Collaborator

erwanp commented Aug 27, 2022

Nice and clear ! Can we add one comma after the database name in the label, not to read "Hitran Pressure" as one block?

@suzil
Copy link
Collaborator Author

suzil commented Aug 27, 2022

Screen Shot 2022-08-27 at 7 03 57 PM

@erwanp updated to add that comma, anything else?

@suzil suzil force-pushed the overlay-spectra-452 branch from 43ebad2 to eafc934 Compare August 27, 2022 23:04
@erwanp
Copy link
Collaborator

erwanp commented Aug 27, 2022

LGTM

@suzil suzil merged commit 3943b3c into main Aug 28, 2022
@suzil suzil deleted the overlay-spectra-452 branch August 28, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay spectra / Clear Button
2 participants