-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for overlaying spectra #646
Conversation
4c44d48
to
4741742
Compare
@minouHub you'll love it |
There's some issue with the species I still need to figure out (you'll notice duplicated labels on the legend), just noticed it |
This is a very game-changing feature ! From a physics point of view, it allows very interesting thing :
I like the Add to Plot syntax rather than the originally suggested Clear button. I'd keep that. Maybe we could rename "Create Plot" to "New Plot" ? |
@erwanp how is this? |
Fixed unit of pressure from atm to bar ^ |
4741742
to
43ebad2
Compare
Nice and clear ! Can we add one comma after the database name in the label, not to read "Hitran Pressure" as one block? |
@erwanp updated to add that comma, anything else? |
43ebad2
to
eafc934
Compare
LGTM |
Screen.Recording.2022-08-27.at.5.10.03.PM.mov
(The missing ylabel has been fixed, don't want to re-demo it)
I've changed the UI slightly from the ticket to instead have:
Would a different UI be better?
I hope it's OK @arunavabasu-03 that I took this ticket 🙈
Closes #452