fix(amazon-cognito-identity-js): Missing cognito user challenge name … (

aws-amplify#10047) * fix(amazon-cognito-identity-js): Missing cognito user challenge name type * fix(type): Fix other functions reported in aws-amplify#6974 * Update Auth units with correct ChallengeName Co-authored-by: elorzafe <elorzafe@amazon.com>
arundna · Jul 6, 2022 · de0441b · de0441b
1 parent 870ec87
commit de0441b
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 16 deletions.
diff --git a/packages/amazon-cognito-identity-js/index.d.ts b/packages/amazon-cognito-identity-js/index.d.ts
diff --git a/packages/auth/__tests__/auth-unit-test.ts b/packages/auth/__tests__/auth-unit-test.ts
@@ -1011,15 +1011,15 @@ describe('auth unit test', () => {
 			const spyon = jest
 				.spyOn(CognitoUser.prototype, 'authenticateUser')
 				.mockImplementationOnce((authenticationDetails, callback) => {
-					callback.mfaRequired('challengeName', 'challengeParam');
+					callback.mfaRequired('SELECT_MFA_TYPE', 'challengeParam');
 				});
 			const auth = new Auth(authOptions);
 			const user = new CognitoUser({
 				Username: 'username',
 				Pool: userPool,
 			});
 			const userAfterSignedIn = Object.assign({}, user, {
-				challengeName: 'challengeName',
+				challengeName: 'SELECT_MFA_TYPE',
 				challengeParam: 'challengeParam',
 			});
 
@@ -1035,15 +1035,15 @@ describe('auth unit test', () => {
 			const spyon = jest
 				.spyOn(CognitoUser.prototype, 'authenticateUser')
 				.mockImplementationOnce((authenticationDetails, callback) => {
-					callback.mfaSetup('challengeName', 'challengeParam');
+					callback.mfaSetup('MFA_SETUP', 'challengeParam');
 				});
 			const auth = new Auth(authOptions);
 			const user = new CognitoUser({
 				Username: 'username',
 				Pool: userPool,
 			});
 			const userAfterSignedIn = Object.assign({}, user, {
-				challengeName: 'challengeName',
+				challengeName: 'MFA_SETUP',
 				challengeParam: 'challengeParam',
 			});
 
@@ -1059,15 +1059,15 @@ describe('auth unit test', () => {
 			const spyon = jest
 				.spyOn(CognitoUser.prototype, 'authenticateUser')
 				.mockImplementationOnce((authenticationDetails, callback) => {
-					callback.totpRequired('challengeName', 'challengeParam');
+					callback.totpRequired('SOFTWARE_TOKEN_MFA', 'challengeParam');
 				});
 			const auth = new Auth(authOptions);
 			const user = new CognitoUser({
 				Username: 'username',
 				Pool: userPool,
 			});
 			const userAfterSignedIn = Object.assign({}, user, {
-				challengeName: 'challengeName',
+				challengeName: 'SOFTWARE_TOKEN_MFA',
 				challengeParam: 'challengeParam',
 			});
 
@@ -1083,15 +1083,15 @@ describe('auth unit test', () => {
 			const spyon = jest
 				.spyOn(CognitoUser.prototype, 'authenticateUser')
 				.mockImplementationOnce((authenticationDetails, callback) => {
-					callback.selectMFAType('challengeName', 'challengeParam');
+					callback.selectMFAType('SELECT_MFA_TYPE', 'challengeParam');
 				});
 			const auth = new Auth(authOptions);
 			const user = new CognitoUser({
 				Username: 'username',
 				Pool: userPool,
 			});
 			const userAfterSignedIn = Object.assign({}, user, {
-				challengeName: 'challengeName',
+				challengeName: 'SELECT_MFA_TYPE',
 				challengeParam: 'challengeParam',
 			});
 
@@ -1403,7 +1403,7 @@ describe('auth unit test', () => {
 			const spyon = jest
 				.spyOn(CognitoUser.prototype, 'completeNewPasswordChallenge')
 				.mockImplementationOnce((password, requiredAttributes, callback) => {
-					callback.mfaRequired('challengeName', 'challengeParam');
+					callback.mfaRequired('SMS_MFA', 'challengeParam');
 				});
 
 			const auth = new Auth(authOptions);
@@ -1422,7 +1422,7 @@ describe('auth unit test', () => {
 			const spyon = jest
 				.spyOn(CognitoUser.prototype, 'completeNewPasswordChallenge')
 				.mockImplementationOnce((password, requiredAttributes, callback) => {
-					callback.mfaSetup('challengeName', 'challengeParam');
+					callback.mfaSetup('MFA_SETUP', 'challengeParam');
 				});
 
 			const auth = new Auth(authOptions);