Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should allow passing error as an argument for done #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apendua
Copy link
Collaborator

@apendua apendua commented Oct 2, 2014

This is a must-have-feature if we want to be able to use promises in tests. Currently, the following test is passing, which is of course an incorrect behavior:

it('Should be able to assert within a promise code.', function (done) {
  Promise.resolve()
    .then(function () {
      expect(true).to.be.false;
    })
    .then(done, done);
});

@apendua apendua mentioned this pull request Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant