Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the possibility to listen to a specific IP, which is useful if I want to host mutiple deployments on the same server and proxy them using virtual hosts. If there is no binding, the servers are also accessible without proxy, using the
PORT
specified inmup.json
file.For example if i configure a nginx vhost with SSL someone can bypass SSL using the configured port.
This (i think) solves Issues #996 and #739
The issue was solved adding the env variable
BIND
which defaults to0.0.0.0
if not specified.I've checked the default value by not specifying the
BIND
parameter, and it works like before (cause of the binding to0.0.0.0
, all interfaces).mup.json
Resulting start.sh file on the server
nginx site
iptables DOCKER chain