Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Deploying with Node 6 #1050

Open
wants to merge 1 commit into
base: mupx
Choose a base branch
from
Open

Fix to Deploying with Node 6 #1050

wants to merge 1 commit into from

Conversation

mkpazon
Copy link

@mkpazon mkpazon commented Jun 7, 2016

When running mupx with Node 6 the following error occurs:

buffer.js:106
      throw new Error(
      ^

Error: If encoding is specified then the first argument must be a string
    at new Buffer (buffer.js:106:13)
    at Readable.<anonymous> (/usr/local/lib/node_modules/mupx/node_modules/archiver/lib/util/index.js:32:15)
    at emitNone (events.js:91:20)
    at Readable.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:926:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

This update fixes the problem.

…ecified then the first argument must be a string
@mkpazon
Copy link
Author

mkpazon commented Jun 7, 2016

Fix to https://github.com/arunoda/meteor-up/issues/1001 "issue mupx deploy #1001" and zodern/meteor-up#985

@MasterJames
Copy link

MasterJames commented Jun 7, 2016

Oh wow is that all? ! Nicely done. I thought it was a Meteor problem and coming soon.
About a month ago I saw a YT video with the dev working on it saying 5 was working and 6 was close. (Can't find it now)
At least to be bundled with meteor. Maybe this is just a change for mupx to work?
Anyway only the new version is accepting PRs kadirahq/meteor-up so maybe see if this helps there too.
Again great find thanks.

@CarlQLange
Copy link

Can this please be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants