Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Timed Metadata for HLS #1584

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

git-audo
Copy link

Hi, I worked on the support for HLS timed metadata as described in the Apple documentation [0]. Since the metadata is required to be in the ID3 format, I included a third party library [1] for the handling of this structure. If this could be of some interest it'd be great to know. I'd really appreciate a review of the added code, if someone has the time to do it. Thank you and good work!

[0] https://developer.apple.com/library/archive/documentation/AudioVideo/Conceptual/HTTP_Live_Streaming_Metadata_Spec/Introduction/Introduction.html
[1] https://github.com/larsbs/id3v2lib

@SeungSeoChoi
Copy link

Is this pullrequest working properly?
When I tried, have an errror that it couldn't find id3v2lib,
Is it solved by just adding the library?

@ssamjh
Copy link

ssamjh commented May 19, 2022

Bump, will this ever be added into the main branch?

@frics
Copy link

frics commented May 19, 2022

Never

@git-audo
Copy link
Author

I would say no, the last PR that was merged to master dates 5 years ago.
Also when I wrote this code I still had a lot to learn, the quality of this implementation is not really that great.
It would definitely need a rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants