Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected Boost dependencies when compile in c++11 mode #3011

Closed
glassez opened this issue May 8, 2018 · 0 comments
Closed

Unexpected Boost dependencies when compile in c++11 mode #3011

glassez opened this issue May 8, 2018 · 0 comments

Comments

@glassez
Copy link
Contributor

glassez commented May 8, 2018

libtorrent version (or branch): RC_1_1

When c++11 is used libtorrent use std::chrono and std::random, but CMake still require boost::chrono and boost::random. Can you make these requirements to be conditional?
zeule added a commit to zeule/libtorrent that referenced this issue May 25, 2018
@zeule
Reflect Boost version and C++11/14 interconnection in CMake build
0a235d6 
C++ standard and Boost requirements are connected:
1. With C++11 onward, we require Boost system component, with
C++03 we need chrono and random components too
2. When building against boost 1.66 and newer, C++11 is required.

Closes arvidn#3011, partially closes arvidn#2966.
zeule added a commit to zeule/libtorrent that referenced this issue May 25, 2018
@zeule
Reflect Boost version and C++11/14 interconnection in CMake build
116c8b6 
C++ standard and Boost requirements are connected:
1. With C++11 onward, we require Boost system component, with
C++03 we need chrono and random components too
2. When building against boost 1.66 and newer, C++11 is required.

Closes arvidn#3011, partially closes arvidn#2966.
@zeule zeule mentioned this issue May 25, 2018
Merged
zeule added a commit to zeule/libtorrent that referenced this issue May 25, 2018
@zeule
Reflect Boost version and C++11/14 interconnection in CMake build
cb39911 
C++ standard and Boost requirements are connected:
1. With C++11 onward, we require Boost system component, with
C++03 we need chrono and random components too
2. When building against boost 1.66 and newer, C++11 is required.

Closes arvidn#3011, partially closes arvidn#2966.
zeule added a commit to zeule/libtorrent that referenced this issue May 25, 2018
@zeule
Reflect Boost version and C++11/14 interconnection in CMake build
ee547e8 
C++ standard and Boost requirements are connected:
1. With C++11 onward, we require Boost system component, with
C++03 we need chrono and random components too
2. When building against boost 1.66 and newer, C++11 is required.

Closes arvidn#3011, partially closes arvidn#2966.
zeule added a commit to zeule/libtorrent that referenced this issue May 25, 2018
@zeule
Reflect Boost version and C++11/14 interconnection in CMake build
8ab5ab7 
C++ standard and Boost requirements are connected:
1. With C++11 onward, we require Boost system component, with
C++03 we need chrono and random components too
2. When building against boost 1.66 and newer, C++11 is required.

Closes arvidn#3011, partially closes arvidn#2966.
zeule added a commit to zeule/libtorrent that referenced this issue May 25, 2018
@zeule
Reflect Boost version and C++11/14 interconnection in CMake build
acf07fb 
C++ standard and Boost requirements are connected:
1. With C++11 onward, we require Boost system component, with
C++03 we need chrono and random components too
2. When building against boost 1.66 and newer, C++11 is required.

Closes arvidn#3011, partially closes arvidn#2966.
@arvidn arvidn closed this as completed in b1d7dd8 May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glassez