Fix build with cmake under windows. #305
Conversation
|
This fixes issue #181 "Cant build libtorrent with Visual Studio 2015.Getting linking error." |
| add_definitions(-D_WIN32_WINNT=0x0600) | ||
| # prevent winsock1 to be included | ||
| add_definitions(-DWIN32_LEAN_AND_MEAN) | ||
| add_definitions(-DWIN32_LEAN_AND_MEAN -DTORRENT_EXPORT_EXTRA) |
There was a problem hiding this comment.
this define should only be added when building tests. is there a way to distinguish that? it's really not a good idea to include it for production builds, it exposes lots of internal functions and classes.
|
Without TORRENT_EXPORT_EXTRA there is a link problem in cpuid.cpp mmx function detection in the user code. Am I doing something wrong? |
|
what's the error? |
|
the appveyor build of the examples, with shared linking, is supposed to catch issues like that. Since that's passing, it's possible there's a configuration issue in the cmake files causing it too |
Fix build with MSVC, let cmake manage boost selection settings.
|
I've updated the patch, thanks for noticing it. It was defined in user code as well, probably what caused the error. Removed from both and it builds fine. |
Fix build with cmake under windows.
Fix build with MSVC, let cmake manage boost selection settings.