Fix num_alert_types #306
Fix num_alert_types #306
Conversation
aldenml
force-pushed
the
fix-log-alerts
branch
4 times, most recently
from
a31686c to
43636fa
Compare
| @@ -2496,7 +2537,7 @@ namespace libtorrent | |||
| #undef TORRENT_DEFINE_ALERT_PRIO | |||
| #undef TORRENT_CLONE | |||
|
|
|||
| enum { num_alert_types = 89 }; | |||
| enum { num_alert_types = 90 }; | |||
There was a problem hiding this comment.
I get this fix.. what about the other changes?
There was a problem hiding this comment.
The other changes are because num_alert_types is not dynamic. It seems to me a little odd not having the right amount of alert types even if TORRENT_DISABLE_LOGGING is defined. Specifically for picker_log_alert there was no constructor if TORRENT_DISABLE_LOGGING and peer_alert has no default constructor.
There was a problem hiding this comment.
ah. the intention of this enum is really "max_alert_index" + 1. It makes it possible to use alert types as indices into a dense array. If some alerts will never actually be posted is not really relevant for that purpose.
are you using it for anything where it's important that it indicates the actual number of alerts that exists?
do you think it should be called something else?
There was a problem hiding this comment.
Actually, I'm compiling with logging enabled. Before give up with this PR in the current form, I will explain a problem I'm facing (see in the PR's comment).
|
rebasing. |
aldenml
force-pushed
the
fix-log-alerts
branch
from
43636fa to
26e8c83
Compare
|
The main motivation of this PR is that I'm dealing with a way to efficiently cast the alerts in a swig/java world. Having the types in a consecutive sequence allows the java compiler apply heavy optimizations in a dense switch/case statement. This optimization can vary with a function of how many cases and how many holes are in the cases. |
|
I will resubmit this PR with a reduced set of changes. |
aldenml
force-pushed
the
fix-log-alerts
branch
from
26e8c83 to
409cfac
Compare
aldenml
changed the title
Fix num_alert_types.