only trigger default listen sockets if the listen_interfaces setting … #4166
Conversation
…is empty The old code would add default listen sockets when listen_interfces was non-empty but only contained invalid interface specifications. In the future it may be possible to support operation with no listen sockets at all, but this will require additional work since the announce code currently requires a listen socket to function.
| { | ||
| // if no listen interfaces are specified, create sockets to use | ||
| // any interface | ||
| m_listen_interfaces = parse_listen_interfaces("0.0.0.0:0,[::]:0"); |
There was a problem hiding this comment.
I think the duplex::only_outgoing flag in the previous code is relevant.
There was a problem hiding this comment.
I seem to recall that the old behavior tried to mimic, as closely as possible, not having any listen sockets. But I think the name is a bit misleading as it is. Since we use these for outgoing connections also. And I think it makes sense to preserve this attempt to not accept incoming connections for an empty string.
But doesn't this still raise the question of what happens when a torrent attempts to announce when there are literally no sockets to use?
|
as far as I can tell, opening the "default listen sockets" is as close as we can get to not opening any at all, since we use these sockets for outgoing connections as well. But the existing code sets the Hence, I think the current code is more correct; if you don't specify any listen interfaces, you won't receive incoming connections. If you have invalid syntax for the listen interfaces, you also won't receiving incoming connections, but at least you'll get errors now. |
…is empty
The old code would add default listen sockets when listen_interfces was
non-empty but only contained invalid interface specifications.
In the future it may be possible to support operation with no listen sockets
at all, but this will require additional work since the announce code currently
requires a listen socket to function.