Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up MSVC compiler flags #7615

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Clean up MSVC compiler flags #7615

merged 2 commits into from
Feb 18, 2024

Commits on Feb 18, 2024

  1. Specify standards conformance mode to MSVC 

    https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170
    @Chocobo1
    Chocobo1 committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    2478fca View commit details
    Browse the repository at this point in the history

  2. Remove unsuitable compiler flag 

    Control of multi-core compilation should be set at the build tool (e.g. MSBuild, ninja, make)
and not as a compiler flag.

Also cmake already append it automatically:
https://github.com/Kitware/CMake/blob/e75afeae5cc1b41e1fb97e1924e6dbcd1e39d91a/CompileFlags.cmake#L118-L134
    @Chocobo1
    Chocobo1 committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    563c7a8 View commit details
    Browse the repository at this point in the history