-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cibuildwheel: Add macOS arm64 support #7727
base: RC_2_0
Are you sure you want to change the base?
Conversation
Note/Review: pypa/cibuildwheel#1926 (comment) |
b8a644f
to
2519f14
Compare
@qstokkink Can you give the created wheels a test? |
6934d07
to
bc511c5
Compare
Works on my machine. 👍 On behalf of the Tribler team, I would like to request you to keep |
bc511c5
to
9639733
Compare
|
fc34c3a
to
c8add64
Compare
Thanks 👍 and, "correct" to 2: I copied the wrong string. |
@qstokkink Just so the Tribler team are aware macOS-12 images are considered Deprecated & will be Removed by end of year! |
🤔 that's sad. It would be nice to get a PyPI release before that gets killed though. |
@xavier2k6 considering the other closed issues, it looks like you can add #7729 to your "Closes" list. |
|
@arvidn Regarding to OpenSSL 1.1.1 End Of Life
libtorrent/tools/cibuildwheel/manylinux/openssl-version.sh Lines 3 to 4 in 2ab8fed
|
6069880
to
1c08548
Compare
@xavier2k6 please re-add |
@DjLegolas I only removed macOS from pull request matrix to reduce building time while I test as I know they work. When I am done, they will be re-added - don't worry. |
{"os": "windows-latest", "CIBW_BUILD": "cp*-win32"}, | ||
{"os": "windows-latest", "CIBW_BUILD": "cp*-win_amd64"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using windows-latest
means that CI will probably break when that version changes. Is there a good reason to use this rather than the specific version of the runner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHA CI use the latest (2) server editions....so 2019/2022 - latest = 2022, latest will eventually become 2025 a few months after being GA & 2019 will become obsolete/removed....at some stage the CI will eventually have to migrate away from obsolete/deprecated OS runners provided by github.
This will be the same for macOS-12 & also your linux CI will have to be changed as Ubuntu-20.04
will be removed soon too.
The only real show stopper here is the windows 32bit failure & to then re-instate the builds I took out while testing. |
Apparently, the 64-bit OpenSSL is found. AFAIK, GitHub Actions runners do not have 32-bit OpenSSL by default. So, you would need to make sure that the 32-bit version is downloaded and installed from somewhere. Judging from the paths in |
@arvidn I'll leave the OpenSSL 32bit installation to you, do you still want to support 32bit?? We also now have a definitive timeline for the deprecation of the macOS-12 runner |
@xavier2k6 Do you have time to experiment a bit with the win32 build? If we're lucky, it could be as simple as inserting the following at line 106 of - name: Install OpenSSL
if: ${{ endsWith(matrix.CIBW_BUILD, 'win32') }}
run: choco install openssl If all checks are green/passing, it would be easier to merge this PR, I guess. |
@qstokkink i'll be able to give that a try in |
0413058
to
1687adb
Compare
vcpkg is on the windows runners, this could be used to install openssl perhaps..... |
ca610f2
to
1c150aa
Compare
@xavier2k6 Thanks for putting some time into this. Using Lines 442 to 446 in 790b662
Lines 473 to 474 in 790b662
Using your log output, switching the four paths to this should work:
My Jam language is a bit rusty. So, this might need to be |
@qstokkink Will make some changes later, will also need to make sure we use the right package as there's 3x release options I believe: I'll have to look at vcpkg port/json files etc. vcpkg gets updated each time there's a newer windows runner image released so that will bring newer versions of OpenSSL. |
Just for motivation/verification: the |
I'm not too sure if the |
@arvidn Do you still plan/want to support 32bit? |
1c150aa
to
32bf296
Compare
Closes #7308.
Closes #7536.
Closes #7650.
Closes #7683.
Closes #7729.