-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plotly backend and gallery prototype #61
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 85.85% 85.14% -0.72%
==========================================
Files 17 20 +3
Lines 1951 2194 +243
==========================================
+ Hits 1675 1868 +193
- Misses 276 326 +50 ☔ View full report in Codecov by Sentry. |
I have added a simpler gallery_generator extension. I would like to change how things are documented a bit, having less examples in the docstring (not no examples though, but mostly examples that complement the docstring) and links from the docstrings to all example gallery pages that use it (where all backends will be shown instead of only matplotlib). Consequently, instead of the python script with a docstring at its top, I think it will be easier to have two files with the same name one python the other markdown. We could go back to single py file with docstring, but I would "simplify" things and have the docstring be valid markdown/myst and added as is to the page for rendering. |
Ready to merge! 🎉 I am quite happy with the example gallery. It has a lot of common elements with the original one: cool css thanks to Sarina, tabs for different backends, link to api docs and to download the script. And in addition it has several improvements:
Regarding plotly, all currenly implemented plots already work, and I have also added initial support for the |
This is really awesome, so I am merging. I have a few nitpicks, that I am listing here. I can open issues later. Marginal distribution comparison plot --- point-estimate overlaps (plotly okish, but not matplotlib), titles overlaps (plotly) |
Issues will be great. Some of them will be fixed by #67 I think (as once implemented all backends should get roughly the same size, and definitely the same aspect ratio). The title overlap is most probably bad plotly usage on my side 😅, and the different colors already have an open issue #56 as this is also an issue in matplotlib when we use plot dist to overlay things on the same plot (automatic cycling works differently in the backends: matplotlib cycles automatically within axes, bokeh does no automatic cycling and plotly cycles automatically within figures) |
📚 Documentation preview 📚: https://arviz-plots--61.org.readthedocs.build/en/61/