Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_pymc3 fails on manually sliced traces #1208

Closed
michaelosthege opened this issue May 25, 2020 · 0 comments
Closed

from_pymc3 fails on manually sliced traces #1208

michaelosthege opened this issue May 25, 2020 · 0 comments

Comments

@michaelosthege
Copy link
Contributor

Describe the bug
When the trace is sliced manually, the n_draws in the sampler report are None, breaking from_pymc3.

Expected behavior
from_pymc3 should just revert to the old strategy.

Additional context

  • latest arviz from master
  • latest pymc3 from master
michaelosthege added a commit to michaelosthege/arviz that referenced this issue May 25, 2020
@michaelosthege
add regression test for arviz-devs#1208
1d288b2
@michaelosthege michaelosthege mentioned this issue May 25, 2020
Merged
4 tasks
michaelosthege added a commit to michaelosthege/arviz that referenced this issue May 25, 2020
@michaelosthege
check if n_draws is available and informative before using it
fe0a175 
+ also warn the user about manually slicing
+ closes arviz-devs#1208
+ bumps to 0.8.2 because of the hotfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelosthege