Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add group argument to plot_joint #1012

Merged
merged 12 commits into from
Jan 20, 2020
Merged

[WIP] Add group argument to plot_joint #1012

merged 12 commits into from
Jan 20, 2020

Conversation

amukh18
Copy link
Contributor

@amukh18 amukh18 commented Jan 18, 2020

Fix #1004

@amukh18
Copy link
Contributor Author

amukh18 commented Jan 18, 2020

@OriolAbril I seem to have accidentally added some commits from another issue I was working on earlier even though I used a different branch. Could you please tell me how I could resolve this(I am a bit new to git)?

@amukh18
Copy link
Contributor Author

amukh18 commented Jan 18, 2020

@OriolAbril Do I need to modify any of the backend files too?

OriolAbril
OriolAbril reviewed Jan 18, 2020
View reviewed changes
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to modify any backend file here, data is already a good name.

@aloctavodia aloctavodia changed the title [WIP] To fix #1004: Add group argument to plot_joint [WIP] Add group argument to plot_joint Jan 20, 2020
@OriolAbril OriolAbril merged commit 4f2afc9 into arviz-devs:master Jan 20, 2020
@amukh18 amukh18 deleted the jointpltgrp branch January 21, 2020 17:38
@amukh18 amukh18 restored the jointpltgrp branch January 21, 2020 17:38
percygautam pushed a commit to percygautam/arviz that referenced this pull request Jan 21, 2020
@amukh18 @percygautam
Add group argument to plot_joint (arviz-devs#1012)
c3836bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add group argument to plot_joint
2 participants
@amukh18 @OriolAbril