Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use get_bins function to compute bins for density and posterior plot #1049

Merged
merged 4 commits into from
Feb 6, 2020
Merged

use get_bins function to compute bins for density and posterior plot #1049

merged 4 commits into from
Feb 6, 2020

Conversation

agustinaarroyuelo
Copy link
Contributor

Hello everyone. I have made some changes in density and posterior plot. Bins were not computed using the get_bins function. Also plot_density did not take the ax argument.

Before
density_before
posterior_before

After
density_after
posterior_after

@aloctavodia
Copy link
Contributor

LGTM. This should be added to the changelog.

OriolAbril
OriolAbril approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@OriolAbril OriolAbril merged commit ecc8468 into arviz-devs:master Feb 6, 2020
@agustinaarroyuelo agustinaarroyuelo deleted the histogram branch February 6, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloctavodia aloctavodia aloctavodia approved these changes

@OriolAbril OriolAbril OriolAbril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agustinaarroyuelo @aloctavodia @OriolAbril