-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traceplot legend #1070
Merged
Merged
Traceplot legend #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behaviour:
How does this look? cc @canyon289 @julian-pani |
OriolAbril
force-pushed
the
traceplot_legend
branch
2 times, most recently
from
February 21, 2020 23:00
43a02ba
to
0191a8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
- Coverage 93.50% 91.24% -2.26%
==========================================
Files 93 93
Lines 8773 8900 +127
==========================================
- Hits 8203 8121 -82
- Misses 570 779 +209
Continue to review full report at Codecov.
|
OriolAbril
force-pushed
the
traceplot_legend
branch
from
February 28, 2020 15:41
0191a8d
to
89ddf54
Compare
OriolAbril
force-pushed
the
traceplot_legend
branch
2 times, most recently
from
February 29, 2020 14:50
c5221f2
to
3867ce1
Compare
OriolAbril
force-pushed
the
traceplot_legend
branch
from
March 1, 2020 16:36
3867ce1
to
408d8fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #837. Allows customization of properties to distinguish lines in the same subplot with all combinations of combine and compact. Introduces arguments
compact_prop
andchain_prop
with format(property_name, (value1, value2...))
to set color, linestyle, linewidth...Matplotlib version is kind of working, only labels are missing, plot format is OK. Bokeh is still more preliminar. It would also be interesting to implement interactive legends in bokeh for traceplot, but I currently do not plan to do this here.
Checklist