-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MultiObservedRVs to observed_data #1098
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 94 94
Lines 9497 9500 +3
=======================================
+ Hits 8846 8849 +3
Misses 651 651
Continue to review full report at Codecov.
|
I have updated code and tests to get |
@OriolAbril Feeling good about this one? Happy to review and merge if so |
Yep, should be ready to merge now. |
Merging |
It should work with the latest ArviZ versions, and IIRC we have some tests to check this works so I have no reason to suspect a regression here for now, there are many other possible issues with dtypes and data conversions. What is the code that generates the model? I would recommend asking a question on PyMC3 discourse (given that you are using pymc, otherwise Stan discourse for example would be equally fine) including the code and the error message so it's easier to find in case someone has the same issue again. Feel free to tag me there, I have the same handle. If you manage to reduce the issue to a minimal reproducible example we can use it to play around and see what the proposed solutions do. |
Description
closes #384. Data from
MultiObservedRV
will now be added toobserved_data
group byfrom_pymc3
Checklist