-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warmup iterations and _group_warmup #1126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
- Coverage 92.70% 92.58% -0.13%
==========================================
Files 93 93
Lines 9023 9129 +106
==========================================
+ Hits 8365 8452 +87
- Misses 658 677 +19
Continue to review full report at Codecov.
|
Hi, we need to decide on a few things
|
This is look great. Thank you Ari! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I figured it could also be of interest to @michaelosthege.
@OriolAbril indeed, thanks! In PyMC3 we recently added properties to track the number of tuning iterations in the sampler report. (The EDIT: forgot to link pymc-devs/pymc#3827 |
Yes, pymc should have this too (and other interfaces). I have used pystan here as a first example. |
Description
Implement save_warmup for PyStan.
Adds
_groups_warmup
toInferenceData
.Warmup groups must start with
_warmup_
.Checklist