Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to display rank plots instead of trace #1134

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Apr 1, 2020

Integrates rank plots into plot_trace via the new keyword kind, defaults to kind=trace

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

kind=rank_vlines
rank_vlines

kind=rank_bars
rank_bars

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1134 into master will increase coverage by 0.12%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   92.68%   92.81%   +0.12%     
==========================================
  Files          93       93              
  Lines        9073     9181     +108     
==========================================
+ Hits         8409     8521     +112     
+ Misses        664      660       -4     
Impacted Files Coverage Δ
arviz/plots/traceplot.py 97.33% <75.00%> (-1.26%) ⬇️
arviz/plots/backends/bokeh/traceplot.py 95.97% <93.33%> (-0.43%) ⬇️
arviz/plots/backends/matplotlib/traceplot.py 99.15% <100.00%> (+0.06%) ⬆️
arviz/data/inference_data.py 81.88% <0.00%> (-1.26%) ⬇️
arviz/utils.py 90.00% <0.00%> (-0.96%) ⬇️
arviz/data/io_pystan.py 98.67% <0.00%> (-0.40%) ⬇️
arviz/stats/stats.py 96.32% <0.00%> (-0.21%) ⬇️
arviz/rcparams.py 93.10% <0.00%> (ø)
arviz/plots/backends/__init__.py 29.11% <0.00%> (ø)
arviz/plots/backends/bokeh/rankplot.py 93.33% <0.00%> (+1.66%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9909aab...67d2324. Read the comment docs.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we need one example for the gallery?

@ahartikainen
Copy link
Contributor

Also changelog needs update

@ahartikainen ahartikainen merged commit 6383820 into master Apr 6, 2020
@aloctavodia aloctavodia deleted the plot_trace_rank branch April 6, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants