Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overlaid pairplots #1135

Merged
merged 4 commits into from
Apr 6, 2020
Merged

allow overlaid pairplots #1135

merged 4 commits into from
Apr 6, 2020

Conversation

OriolAbril
Copy link
Member

Description

Fix issue #1130.

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #1135 into master will increase coverage by 0.21%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
+ Coverage   92.67%   92.89%   +0.21%     
==========================================
  Files          93       93              
  Lines        9097     9102       +5     
==========================================
+ Hits         8431     8455      +24     
+ Misses        666      647      -19     
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/pairplot.py 85.61% <90.00%> (+14.71%) ⬆️
arviz/data/converters.py 68.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca28da...6dd8096. Read the comment docs.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahartikainen ahartikainen merged commit 1b2ecdd into master Apr 6, 2020
@ahartikainen
Copy link
Contributor

I noticed changelog needs updating, but let's do that in another PR then

ahartikainen added a commit that referenced this pull request Apr 6, 2020
ahartikainen added a commit that referenced this pull request Apr 6, 2020
@ahartikainen ahartikainen deleted the i1130 branch April 6, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants